-
Notifications
You must be signed in to change notification settings - Fork 104
feat(relay): Remove static mode #5108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relay): Remove static mode #5108
Conversation
| "static" => Err(serde::de::Error::custom( | ||
| "Relay mode 'static' has been depreciated. Please use 'managed' or 'proxy' instead.", | ||
| )), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it makes sense to link to the docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
I think you can remove the existing changelog line about static mode and instead add a line about the complete removal to |
Co-authored-by: Joris Bayer <[email protected]>
This is a big change, however this should not break anything. Users that run Relay in Proxy mode should not experience any negative side effects. With the recent changes to the Relay modes (#5108, #5057, #5053) it became apparent that the proxy mode is currently doing more than strictly necessary. That is, the logic is currently more complex than it needs to be and as such it also is less efficient than it could be. This PR tries to rectify this by making Proxy mode more of a 'pure' Proxy by introducing the `ProxyProcessorService` which is a simplified version of the `EnvelopeProcessorService`. There are also some changes to the `HealthCheckService`, `AutoscalingMetricService` and `RelayStats` to make these compatible. Fixes: https://linear.app/getsentry/issue/INGEST-581/simplify-proxy-mode
This is a big change, however this should not break anything. Users that run Relay in Proxy mode should not experience any negative side effects. With the recent changes to the Relay modes (#5108, #5057, #5053) it became apparent that the proxy mode is currently doing more than strictly necessary. That is, the logic is currently more complex than it needs to be and as such it also is less efficient than it could be. This PR tries to rectify this by making Proxy mode more of a 'pure' Proxy by introducing the `ProxyProcessorService` which is a simplified version of the `EnvelopeProcessorService`. There are also some changes to the `HealthCheckService`, `AutoscalingMetricService` and `RelayStats` to make these compatible. Fixes: https://linear.app/getsentry/issue/INGEST-581/simplify-proxy-mode
This needs to be coordinated with changes in Sentry that make managed mode available to everyone and an updating of the docs telling people managed mode is now available.
Sentry PRs: getsentry/sentry#98696 & getsentry/sentry#98688
Docs PR: getsentry/sentry-docs#14787
Ref: https://linear.app/getsentry/issue/INGEST-545/update-relay